The return value of lpuart_dma_tx_request() is a negative errno on failure and zero on success. Fixes: 159381df1442f ("tty: serial: fsl_lpuart: fix DMA operation when using IOMMU") Reported-by: Leonard Crestez <leonard.crestez@xxxxxxx> Signed-off-by: Michael Walle <michael@xxxxxxxx> --- drivers/tty/serial/fsl_lpuart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index 960fc2658f19..bbba298b68a4 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -1522,7 +1522,7 @@ static void lpuart_tx_dma_startup(struct lpuart_port *sport) } ret = lpuart_dma_tx_request(&sport->port); - if (!ret) + if (ret) goto err; init_waitqueue_head(&sport->dma_wait); -- 2.20.1