On 18. 03. 20, 23:38, Eric Biggers wrote: > --- a/drivers/tty/vt/vt.c > +++ b/drivers/tty/vt/vt.c > @@ -1102,6 +1102,9 @@ int vc_allocate(unsigned int currcons) /* return 0 on success */ > tty_port_init(&vc->port); > INIT_WORK(&vc_cons[currcons].SAK_work, vc_SAK); > > + /* if this wasn't the case, we'd have to implement port->ops.destruct */ > + BUILD_BUG_ON(offsetof(struct vc_data, port) != 0); > + This is 3 lines, implementing destruct would be like 4-5 :)? Please implement destruct instead. Otherwise looks good. thanks, -- js suse labs
