On Tue, Feb 25, 2020 at 5:57 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Tue, 25 Feb 2020 09:46:45 +0100, Mateusz Holenko wrote: > > From: Pawel Czarnecki <pczarnecki@xxxxxxxxxxxxxxxxxxxxxxxx> > > > > Add documentation for LiteX SoC Controller bindings. > > > > Signed-off-by: Pawel Czarnecki <pczarnecki@xxxxxxxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Mateusz Holenko <mholenko@xxxxxxxxxxxx> > > --- > > > > Notes: > > This commit has been introduced in v3 of the patchset. > > > > .../soc/litex/litex,soc_controller.yaml | 46 +++++++++++++++++++ > > MAINTAINERS | 6 +++ > > 2 files changed, 52 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/litex/litex,soc_controller.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > warning: no schema found in file: Documentation/devicetree/bindings/soc/litex/litex,soc_controller.yaml > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/litex/litex,soc_controller.yaml: ignoring, error parsing file > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node > Traceback (most recent call last): > File "/usr/local/bin/dt-doc-validate", line 35, in check_doc > testtree = dtschema.load(filename, line_number=line_number, duplicate_keys=False) > File "/usr/local/lib/python3.6/dist-packages/dtschema/lib.py", line 513, in load > return yaml.load(f.read()) > File "/usr/local/lib/python3.6/dist-packages/ruamel/yaml/main.py", line 343, in load > return constructor.get_single_data() > File "/usr/local/lib/python3.6/dist-packages/ruamel/yaml/constructor.py", line 111, in get_single_data > node = self.composer.get_single_node() > File "_ruamel_yaml.pyx", line 718, in _ruamel_yaml.CParser.get_single_node > ruamel.yaml.composer.ComposerError: expected a single document in the stream > in "<unicode string>", line 1, column 1 > but found another document > in "<unicode string>", line 2, column 1 > > During handling of the above exception, another exception occurred: > > Traceback (most recent call last): > File "/usr/local/bin/dt-doc-validate", line 74, in <module> > ret = check_doc(args.yamldt) > File "/usr/local/bin/dt-doc-validate", line 40, in check_doc > print(filename + ":", exc.path[-1], exc.message) > AttributeError: 'ComposerError' object has no attribute 'path' > Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/soc/litex/litex,soc_controller.example.dts' failed > make[1]: *** [Documentation/devicetree/bindings/soc/litex/litex,soc_controller.example.dts] Error 1 > Makefile:1263: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > > See https://patchwork.ozlabs.org/patch/1243930 > Please check and re-submit. Thanks for spotting this. It looks like the first line of the document is broken - it should be a comment with a license descriptor, but the initial characters are missing. I'll fix this and resubmit the whole patchset after addressing all other remarks. -- Mateusz Holenko Antmicro Ltd | www.antmicro.com Roosevelta 22, 60-829 Poznan, Poland
