Re: [PATCH v1 1/4] serial: core: Use string length for SysRq magic sequence

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/10/20 4:48 PM, Andy Shevchenko wrote:
> 
> Have you seen to the assembly?
> 
> For me it seems that GCC is clever enough to precalc length for constant
> literals.
> 
> With default string (empty) there is no uart_sysrq_on() at all in the code.
> 
> With "pqr" I see this function and in particular:
>      621:       be 03 00 00 00          mov    $0x3,%esi
> 
> With "pqrst"
> 
>      621:       be 05 00 00 00          mov    $0x5,%esi
> 
> (Note, I compiled entire series, that's why uart_sysrq_on() has strlen() in)

Ah, that solves all worries I have.

Thanks again,
          Dmitry



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux