On Mon, Mar 02, 2020 at 11:11:17AM +0100, Linus Walleij wrote: > This driver for the Intel MID never seems to have been properly > integrated upstream: the platform data in <linux/spi/ifx_modem.h> > is not used anywhere in the kernel and haven't been since it was > merged into the kernel in 2010. > > There might be out-of-tree users, so I don't want to delete the > driver, but I will refactor it to use GPIO descriptors, which > means that out-of-tree users will need to adapt. > > There are several examples in the kernel of how to provide the > resources necessary for using GPIO descriptors to pass in the > GPIO lines, for the MID platform in particular, it will suffice > to inspect the code in files like: > arch/x86/platform/intel-mid/device_libs/platform_bt.c > > This refactoring transfers all GPIOs in the driver, including > a hard-coded "PMU reset" in the driver to use GPIO descriptors > instead. > > The following named GPIO descriptors need to be supplied: > - reset > - power > - mrdy > - srdy > - rst_out > - pmu_reset > > Cc: Russ Gorby <russ.gorby@xxxxxxxxx> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > drivers/tty/serial/ifx6x60.c | 170 ++++++++++++---------------------- > drivers/tty/serial/ifx6x60.h | 13 ++- > include/linux/spi/ifx_modem.h | 5 - > 3 files changed, 65 insertions(+), 123 deletions(-) This fails to apply to my tty-next branch, can you rebase and resend? thanks, greg k-h
