Hi Greg, On 2/20/20 11:26 AM, Greg Kroah-Hartman wrote: > There is no need to tie this driver to only a specific SoC, or compile > test, so remove that dependancy from the Kconfig rules. samsung_tty driver is hardware specific driver so why should we build it for any platform? This change seems to defeat the whole purpose behind COMPILE_TEST config option (which allows us to build hardware-specific drivers without needlessly presenting the user with tons of non-relevant config options). Please explain this change some more, are you planing to remove COMPILE_TEST config option? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > Cc: Kukjin Kim <kgene@xxxxxxxxxx> > Cc: Donghoon Yu <hoony.yu@xxxxxxxxxxx> > Cc: Hyunki Koo <kkoos00@xxxxxxxxx> > Cc: HYUN-KI KOO <hyunki00.koo@xxxxxxxxxxx> > Cc: Shinbeom Choi <sbeom.choi@xxxxxxxxxxx> > Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Cc: Jiri Slaby <jslaby@xxxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Cc: linux-samsung-soc@xxxxxxxxxxxxxxx > Cc: linux-serial@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > --- > drivers/tty/serial/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index 52eaac21ff9f..a310bd22f1e2 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -237,7 +237,6 @@ config SERIAL_CLPS711X_CONSOLE > > config SERIAL_SAMSUNG > tristate "Samsung SoC serial support" > - depends on PLAT_SAMSUNG || ARCH_EXYNOS || COMPILE_TEST > select SERIAL_CORE > help > Support for the on-chip UARTs on the Samsung S3C24XX series CPUs, > > base-commit: 11a48a5a18c63fd7621bb050228cebf13566e4d8
