On Wed, 2020-02-19 at 09:40 +0100, Jiri Slaby wrote:
> With pr_debug we have a fine-grained control about debugging prints. So
> convert the use of global debuglevel variable and tests to a commonly
> used pr_debug. And drop debuglevel completely.
>
> This also implicitly adds a loglevel to the messages (KERN_DEBUG) as it
> was missing on most of them.
[]
> diff --git a/drivers/tty/n_hdlc.c b/drivers/tty/n_hdlc.c
[]
> @@ -310,11 +306,9 @@ static int n_hdlc_tty_open (struct tty_struct *tty)
> {
> struct n_hdlc *n_hdlc = tty2n_hdlc (tty);
>
> - if (debuglevel >= DEBUG_LEVEL_INFO)
> - printk("%s(%d)n_hdlc_tty_open() called (device=%s)\n",
> - __FILE__,__LINE__,
> - tty->name);
> -
> + pr_debug("%s(%d)%s() called (device=%s)\n",
> + __FILE__, __LINE__, __func__, tty->name);
Perhaps remove all the __FILE__ and __LINE__ arguments as
dynamic debug could emit module and __LINE__ when necessary.
