On Fri, Feb 14, 2020 at 08:28:47AM -0800, Greg Kroah-Hartman wrote: > On Fri, Feb 14, 2020 at 01:43:35PM +0200, Andy Shevchenko wrote: ... > > static DEVICE_ATTR(iomem_base, 0440, uart_get_attr_iomem_base, NULL); > > static DEVICE_ATTR(iomem_reg_shift, 0440, uart_get_attr_iomem_reg_shift, NULL); > > +static DEVICE_ATTR(console, 0640, uart_get_attr_console, uart_set_attr_console); > > Again, DEVICE_ATTR_RW() in the future? Fixed for next version, thanks! -- With Best Regards, Andy Shevchenko