Michał Mirosław <mirq-linux@xxxxxxxxxxxx> writes:
> On Mon, Jan 20, 2020 at 04:38:16PM +0300, Sergey Organov wrote:
>> Michał Mirosław <mirq-linux@xxxxxxxxxxxx> writes:
>>
>> > On Mon, Jan 20, 2020 at 09:06:18AM +0300, Sergey Organov wrote:
>> >> Michał Mirosław <mirq-linux@xxxxxxxxxxxx> writes:
>> >> > The pr_debug() in other callers of gs_start_tx() say:
>> >> > "caller: start ttyGS%d".
>> >>
>> >> ???
>> >>
>> >> $ git co gregkh/tty-next && grep -r 'caller: start tty' .
>> >> HEAD is now at 7788f54... serial_core: Remove unused member in uart_port
>> >> $
>> >
>> > Replace 'caller' with a function calling gs_start_io().
>>
>> Thanks, now I see... Do you prefer:
>>
>> pr_debug("gs_start_io: start Tx on ttyGS%d\n", port->port_num);
>>
>> then?
>>
>> Alternatively, I'm OK with removing this new debug print.
>
> Let's remove it. I was convinced that this is a caller of gs_start_io()
> and not the function itself. In this case callers already do the
> print.
OK.
> BTW, the callers silently ignore (error) returns from this function. It
> might be useful to add pr_err() catching the errors.
... or actually handle the error returns? Anyway, that's beyond the
scope of the patch and my expertise.
I've sent re-roll of the patch according to our discussion.
Thanks,
-- Sergey
