Magic sysrq has proven for Arista usecases to be useful for debugging issues in field, over serial line when the switch is in such bad state that it can't accept network connections anymore. Unfortunately, having sysrq always enabled doesn't work for some embedded boards that tend to generate garbage on serial line (including BREAKs). Since commit 732dbf3a6104 ("serial: do not accept sysrq characters via serial port"), it's possible to keep sysrq enabled, but over serial line. Add a way to enable sysrq on a uart, where currently it can be constantly either on or off (CONFIG_MAGIC_SYSRQ_SERIAL). While doing so, cleanup __sysrq_enabled and serial_core header file. Sending against -next tree as it's based on removing SUPPORT_SYSRQ ifdeffery [1]. [1]: https://lkml.kernel.org/r/20191213000657.931618-1-dima@xxxxxxxxxx Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Cc: Jiri Slaby <jslaby@xxxxxxxx> Cc: Vasiliy Khoruzhick <vasilykh@xxxxxxxxxx> Cc: linux-serial@xxxxxxxxxxxxxxx Thanks, Dmitry Dmitry Safonov (3): serial_core: Move sysrq functions from header file sysctl/sysrq: Remove __sysrq_enabled copy serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE drivers/tty/serial/serial_core.c | 123 +++++++++++++++++++++++++++++++ drivers/tty/sysrq.c | 7 ++ include/linux/serial_core.h | 86 ++------------------- include/linux/sysrq.h | 1 + kernel/sysctl.c | 41 ++++++----- lib/Kconfig.debug | 8 ++ 6 files changed, 167 insertions(+), 99 deletions(-) -- 2.24.1