On Mon, Jan 06, 2020 at 07:58:16PM +0100, Greg Kroah-Hartman wrote: > On Sat, Jan 04, 2020 at 12:23:14PM -0800, Dmitry Torokhov wrote: > > The node pointer in question is not a child node, but the node assigned > > to the port device itself, so we should not be using > > devm_fwnode_get_gpiod_from_child() [that is going away], but standard > > devm_gpiod_get(). > > > > To maintain the previous labeling we use gpiod_set_consumer_name() after > > we acquire the GPIO. > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > --- > > drivers/tty/serial/st-asc.c | 12 +++++------- > > 1 file changed, 5 insertions(+), 7 deletions(-) > > What changed from v1 of this patch? Please put that below the --- line > and versino your patches. I did not add a version or changelog because I believe this is essentially a different patch, with different justification and different API that is being used. The first one was a simple switch to devm_fwnode_gpiod_get(), the new one is abandoning the use of explicit node reference, and instead uses standard devm_gpiod_get() to get a GPIO assigned to a device + gpiod_set_consumer_name() to maintain the naming. Thanks. -- Dmitry
