On Fri, Dec 20, 2019 at 10:08:03AM -0800, Linus Torvalds wrote: > On Thu, Dec 19, 2019 at 11:07 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > The last tty core fix should resolve a long-standing bug with a race > > at port creation time that some people would see, and Sudip finally > > tracked down. > > Hmm, looks good. But it makes me wonder if we should now try to remove > the second call to tty_port_link_device()? > > Now we have a number of helpers that do that tty_port_link_device() > call for the driver (eg tty_port_register_device_attr_serdev(), > tty_port_register_device_attr(), and the just added > uart_add_one_port()). > > But we also have drivers doing it by hand, and presumably we now have > drivers that do it through multiple paths? I guess it's harmless, but > it feels a bit odd. No? It does. I'll try to look at this after the holidays unless Sudip beats me to it. thanks, greg k-h
