On 12/19/19 7:34 AM, Greg Kroah-Hartman wrote: > On Thu, Dec 19, 2019 at 03:24:01PM +0800, kbuild test robot wrote: >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing >> head: 82cfd2e62b354840af6a045e084f6e9e7c49584d >> commit: 1997e9dfdc84c8f73d6fc318355cf9e313aba183 [23/75] serial_core: Un-ifdef sysrq SUPPORT_SYSRQ >> config: arm-randconfig-a001-20191219 (attached as .config) >> compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0 >> reproduce: >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> git checkout 1997e9dfdc84c8f73d6fc318355cf9e313aba183 >> # save the attached .config to linux build tree >> GCC_VERSION=7.5.0 make.cross ARCH=arm >> >> If you fix the issue, kindly add following tag >> Reported-by: kbuild test robot <lkp@xxxxxxxxx> >> >> All error/warnings (new ones prefixed by >>): >> >> In file included from include/linux/kernel.h:11:0, >> from include/linux/list.h:9, >> from include/linux/module.h:12, >> from drivers/tty/serial/21285.c:7: >> drivers/tty/serial/21285.c: In function 'serial21285_stop_tx': >>>> drivers/tty/serial/21285.c:44:41: error: subscripted value is neither array nor pointer nor vector >> #define tx_enabled(port) ((port)->unused[0]) >> ^ > > Ugh, this driver did the same hack the samsung_tty driver did! That's > where samsung got the idea. > > I'll go fix this up as well... Sorry that you had to clean that up - I should have checked that, rather than blindly believe that if something is called "unused" it's actually unused. Thanks again, Dmitry
