On Wed, Dec 18, 2019 at 03:00:16PM +0100, Greg Kroah-Hartman wrote: > On Wed, Dec 18, 2019 at 02:11:54PM +0100, Johan Hovold wrote: > > This reverts commit 54edb425346a4d5e17f7e54e8c97c0d0eac26315. > > > > The offending commit caused serdev core to always be built-in, something > > which breaks the build of dependent modules when serdev is being built > > as a module: > > > > ERROR: "__serdev_device_driver_register" [drivers/gnss/gnss-ubx.ko] undefined! > > ... > > make[2]: *** [/home/johan/work/omicron/src/linux/scripts/Makefile.modpost:94: __modpost] Error 1 > > > > Reported-by: kbuild test robot <lkp@xxxxxxxxx> > > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx> > > --- > > drivers/tty/serdev/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Heh, give me a chance to catch up here, I would have reverted it on my > own :) Heh, good. :) > I'll go queue this up now, thanks. Johan
