On Tue, Dec 17, 2019 at 03:47:34PM +0000, Dmitry Safonov wrote: > On 12/17/19 2:02 PM, Greg Kroah-Hartman wrote: > > The samsung_tty driver was trying to abuse the struct uart_port by using > > two "empty" bytes for its own use. That's not ok, and was found by > > removing those fields from the structure. > > > > Move the variables into the port-specific structure, which is where > > everything else for this port already is. There is no space wasted here > > as there was an empty "hole" in the structure already for these bytes. > > Thanks! > Sorry for not noticing this myself. You wouldn't have noticed this unless you build for that platform. I just recently made it buildable for other ones. > > > Cc: Kukjin Kim <kgene@xxxxxxxxxx> > > Cc: Hyunki Koo <kkoos00@xxxxxxxxx> > > Cc: HYUN-KI KOO <hyunki00.koo@xxxxxxxxxxx> > > Cc: Shinbeom Choi <sbeom.choi@xxxxxxxxxxx> > > Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > Cc: Dmitry Safonov <dima@xxxxxxxxxx> > > Cc: Jiri Slaby <jslaby@xxxxxxxx> > > Cc: linux-serial@xxxxxxxxxxxxxxx > > Cc: linux-kernel@xxxxxxxxxxxxxxx > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > I see you already applied it to your tree, but in case it helps anything: > Reviewed-by: Dmitry Safonov <dima@xxxxxxxxxx> The review helps, thanks :) greg k-h
