On Tue, Dec 17, 2019 at 09:17:15AM +0100, Uwe Kleine-König wrote: > Hello, > > back in November last year I sent my last approach to implement an led > trigger for UARTs (Message-Id: > 20181106213739.29628-1-u.kleine-koenig@xxxxxxxxxxxxxx). This was parked > on my todo list since then somewhere far from the top. > > This is a new approach. Similar to the netdev trigger the tty trigger > introduced here periodically checks the statistics related to a given > tty and if that changed the LED is flashed once. > > I had to introduce two functions in the tty layer to be able to get my > hands on the needed data in the first two patches, the third patch then > adds the trigger. I like the idea, seems sane. Minor code nits on the implementation though... thanks, greg k-h
