On Fri, 13 Dec 2019, at 10:36, Dmitry Safonov wrote: > The SUPPORT_SYSRQ ifdeffery is not nice as: > - May create misunderstanding about sizeof(struct uart_port) between > different objects > - Prevents moving functions from serial_core.h > - Reduces readability (well, it's ifdeffery - it's hard to follow) > > In order to remove SUPPORT_SYSRQ, has_sysrq variable has been added. > Initialise it in driver's probe and remove ifdeffery. > > Cc: Andrew Jeffery <andrew@xxxxxxxx> > Cc: Joel Stanley <joel@xxxxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Cc: linux-aspeed@xxxxxxxxxxxxxxxx > Signed-off-by: Dmitry Safonov <dima@xxxxxxxxxx> Acked-by: Andrew Jeffery <andrew@xxxxxxxx>
