On Thu, Dec 12, 2019 at 08:09:49AM -0800, Christoph Hellwig wrote: > On Thu, Dec 12, 2019 at 12:08:34PM +0100, Greg Kroah-Hartman wrote: > > Yes. It's a long-time checkpatch warning, it's good to be explicit for > > this type of thing. > > There is literally no practical benefit going either way. It is > just checkpatch forcing one personal opinion on people. Fair enough, but, I was trying to align up the variables to be the same type that was then used in a function call. That's the only reason I made this change. thanks, greg k-h