On Wed, Dec 11, 2019 at 12:01:28PM +0100, Enrico Weigelt, metux IT consult wrote: > On 10.12.19 15:36, Greg Kroah-Hartman wrote: > > Hi, > > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > > index 83fd51607741..67c5a84d0a26 100644 > > --- a/drivers/tty/serial/samsung_tty.c > > +++ b/drivers/tty/serial/samsung_tty.c > > @@ -1851,7 +1851,10 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, > > > > /* Device driver serial port probe */ > > > > +#ifdef CONFIG_OF > > static const struct of_device_id s3c24xx_uart_dt_match[]; > > +#endif > > + > > By the way: I've got some patch for conditionally declaring of match > tables (including MODULE_DEVICE_TABE() call), so such ifdef's aren't > needed anymore. That's not why this #ifdef is needed. greg k-h
