On 11/22/2019 11:52 PM, Stephen Boyd wrote:
Quoting Akash Asthana (2019-11-22 06:18:19)
Add system wakeup capability over UART RX line for wakeup capable UART.
When system is suspended, RX line act as an interrupt to wakeup system
for any communication requests from peer.
Signed-off-by: Akash Asthana <akashast@xxxxxxxxxxxxxx>
Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
One question below.
@@ -1330,6 +1354,10 @@ static int qcom_geni_serial_remove(struct platform_device *pdev)
struct uart_driver *drv = port->uport.private_data;
uart_remove_one_port(drv, &port->uport);
+
+ device_init_wakeup(&pdev->dev, false);
+ dev_pm_clear_wake_irq(&pdev->dev);
Should this order be swapped? Usually remove is done in reverse of probe
order, so clear_wake_irq, init wakeup, and remove uart port. I'm not
convinced it will actually matter though so maybe this isn't a problem.
Ok, I will update the order here.
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
