On 15/11/2019 05.25, Timur Tabi wrote:
> On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes
> <linux@xxxxxxxxxxxxxxxxxx> wrote:
>>
>> + if (of_property_read_u32(np, "cell-index", &val) &&
>> + of_property_read_u32(np, "device-id", &val)) {
>
> I know that this is technically correct, but it's obfuscated IMHO.
> 'val' is set correctly only when of_property_read_u32(...) is "false",
> which is doubly-weird because of_property_read_u32(...) doesn't
> actually return a boolean.
>
> I would rather you break this into two if-statements like the original code.
>
Sure, I can do that.
