Re: [PATCHv5] serial-uartlite: Remove ULITE_NR_PORTS macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 13, 2019 at 12:00:08PM +0000, shubhrajyoti.datta@xxxxxxxxx wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
> 
> This patch is removing ULITE_NR_PORTS macro which limits number of
> ports which can be used. Every instance is registering own struct
> uart_driver with minor number which corresponds to alias ID (or 0 now).
> and with 1 uart port. The same alias ID is saved to
> tty_driver->name_base which is key field for creating ttyULX name.
> 
> Because name_base and minor number are setup already there is no need to
> setup any port->line number because 0 is the right value.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
> ---
> v4: patch addition
> v5: Merge the patch so that all the patches compile

Greg, 

Please do not merge this. This is a hack which really needs to be
reconsidered as I've pointed before

	 https://lkml.kernel.org/r/20190523091839.GC568@localhost

I suggest you also drop the first two patches that you applied to
tty-testing earlier today.

Shubhrajyoti, please keep on CC with these changes. I'll try to review
this again and get back to you shortly.

Johan



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux