On 01/11/2019 17.19, Christophe Leroy wrote: > Le 01/11/2019 à 13:42, Rasmus Villemoes a écrit : >> This driver uses #defines from soc/fsl/cpm.h, so instead of relying on >> some other header pulling that in, do that explicitly. This is >> preparation for allowing this driver to build on ARM. >> > > UCC are only on QE. > CPM has SCCs. instead. > So this driver shouldn't need cpm.h But it does. At the very least for the BD_SC_* defines, possibly others things. It's possible one could split off the common part to a separate header, but that sort of cleanup/refactoring is beyond what I'd be comfortable including in this series. Rasmus