[ Sorry, for previous HTML email, trying to send patches from work machine for the first time, re-sending in text ] On Fri, 4 Oct 2019 at 14:29, John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx> wrote: > > On 10/4/19 3:20 PM, Pascal Terjan wrote: > > The only code mentioning it doesn't build (and hasn't at least since git) > > and doesn't include the header defining it. > What do you mean, amiserial doesn't build? The code doesn't build if enabling the "option" SERIAL_PARANOIA_CHECK in the file, this patch is removing that option and he code protected by it > root@elgar:~> grep AMIGA_BUILTIN_SERIAL /boot/config-$(uname -r) > CONFIG_AMIGA_BUILTIN_SERIAL=y > root@elgar:~> > > root@elgar:~> uname -a > Linux elgar 5.2.0-2-m68k #1 Debian 5.2.9-2 (2019-08-21) m68k GNU/Linux > root@elgar:~> > > We're using this driver, it works just fine. > > And I'm not sure what SERIAL_MAGIC does. Is that for CONFIG_MAGIC_SYSRQ_SERIAL? It used to be a magic number in the struct to verify you are getting the expected object > Because we still use that, too. Although I haven't tested it for a while but > I'm using the serial console on my Amiga 4000 right now using amiserial.c. >
