On 32 bit arm platforms (am335x and sunxi) I get unexpected bytes on
serial ports after this commit.
I use CTS (so: for input flow control).
I've observed two different issues, one where I get just a few missed
or added bytes about once a minute, and another where I get totally
unexpected chars until I reopen the port.
I will have a hard time to analyse and give a better description of
how exactly the port is failing, so maybe you have a idea of what is
the issue with this patch.
I've reverted this on top of 5.3.1 and consistently got the issue fixed.
Thanks,
Nuno
commit 4a96895f74c9633b51427fd080ab70fa62b65bc4
Author: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
Date: Thu Jun 20 08:24:20 2019 +0200
tty/serial/8250: use mctrl_gpio helpers
This patch permits the usage for GPIOs to control
the CTS/RTS/DTR/DSR/DCD/RI signals.
Changed by Stefan:
Only call mctrl_gpio_init(), if the device has no ACPI companion device
to not break existing ACPI based systems. Also only use the mctrl_gpio_
functions when "gpios" is available.
Use MSR / MCR <-> TIOCM wrapper functions.
Signed-off-by: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
Signed-off-by: Stefan Roese <sr@xxxxxxx>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
Tested-by: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Cc: Giulio Benetti <giulio.benetti@xxxxxxxxxxxxxxxx>
Cc: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
