Re: [PATCH v3] 8250_lpss: check null return when calling pci_ioremap_bar

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Navid Emamdoost <navid.emamdoost@xxxxxxxxx>
Subject: Re: [PATCH v3] 8250_lpss: check null return when calling pci_ioremap_bar
From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Date: Sat, 7 Sep 2019 19:16:07 +0300
Cc: Navid Emamdoost <emamd001@xxxxxxx>, Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Jiri Slaby <jslaby@xxxxxxxx>, Vinod Koul <vkoul@xxxxxxxxxx>, linux-serial@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <CAEkB2ET-SQFiBbroxDFEVrPxto6a2wLJf0NM7R=ERcPargr66Q@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20190726115746.GT9224@smile.fi.intel.com> <20190726195345.30294-1-navid.emamdoost@gmail.com> <CAEkB2ERhxLj7ogoy1E3j8d4MyEZqroWS1tPRxyJXR2oLhNz+LQ@mail.gmail.com> <20190907155342.GG2680@smile.fi.intel.com> <CAEkB2ET-SQFiBbroxDFEVrPxto6a2wLJf0NM7R=ERcPargr66Q@mail.gmail.com>
User-agent: Mutt/1.10.1 (2018-07-13)

On Sat, Sep 07, 2019 at 11:06:29AM -0500, Navid Emamdoost wrote:
> Cool! I thought it is forgotten, as there were no response to the v3 of the
> patch.

Nevertheless, you may send a follow up, since one call to pci_iounmap() is
missed when dw_dma_probe() fails.

> Thanks for letting me know.

You're welcome.

-- 
With Best Regards,
Andy Shevchenko

References:
- Re: [PATCH v2] 8250_lpss: check null return when calling pci_ioremap_bar
  - From: Andy Shevchenko
- [PATCH v3] 8250_lpss: check null return when calling pci_ioremap_bar
  - From: Navid Emamdoost
- Re: [PATCH v3] 8250_lpss: check null return when calling pci_ioremap_bar
  - From: Andy Shevchenko

Prev by Date: Re: [PATCH v3] 8250_lpss: check null return when calling pci_ioremap_bar
Next by Date: [PATCH] tty: serial: owl: Fix the link time qualifier of 'owl_uart_exit()'
Previous by thread: Re: [PATCH v3] 8250_lpss: check null return when calling pci_ioremap_bar
Next by thread: Re: [PATCH] 8250_lpss: check null return when calling pci_ioremap_bar
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux PPP] [Linux FS] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Linmodem] [Device Mapper] [Linux Kernel for ARM]