Hi Greg, Jiri, Since commit 1d267ea6539f2663 ("serial: mctrl-gpio: simplify init routine"), mctrl_gpio_init() returns failure if the assignment to any member of the gpio array results in an error pointer. Since commit c359522194593815 ("serial: mctrl_gpio: Avoid probe failures in case of missing gpiolib"), mctrl_gpio_to_gpiod() returns NULL in the !CONFIG_GPIOLIB case. Hence there is no longer a need to check in serial drivers if mctrl_gpio_to_gpiod() returns an error value. A simple NULL check is sufficient. This series follows the spirit of commit 445df7ff3fd1a0a9 ("serial: mctrl-gpio: drop usages of IS_ERR_OR_NULL") in the mctrl-gpio core. Thanks! Geert Uytterhoeven (3): serial: atmel: Don't check for mctrl_gpio_to_gpiod() returning error serial: mxs-auart: Don't check for mctrl_gpio_to_gpiod() returning error serial: sh-sci: Don't check for mctrl_gpio_to_gpiod() returning error drivers/tty/serial/atmel_serial.c | 12 ++++-------- drivers/tty/serial/mxs-auart.c | 6 ++---- drivers/tty/serial/sh-sci.c | 12 +++++------- 3 files changed, 11 insertions(+), 19 deletions(-) -- 2.17.1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds