Hi, On Thu, Aug 08, 2019 at 12:47:00PM +0000, Stefan-gabriel Mirea wrote: > On 8/8/2019 11:08 AM, Will Deacon wrote: > > On Fri, Aug 02, 2019 at 07:47:23PM +0000, Stefan-gabriel Mirea wrote: > >> + linflex,<addr> > >> + Use early console provided by Freescale LinFlex UART > >> + serial driver for NXP S32V234 SoCs. A valid base > >> + address must be provided, and the serial port must > >> + already be setup and configured. > > > > Why isn't earlycon= sufficient for this? > > "earlycon=" is not actually supported. I will fix this in the next > version by adding a /chosen/stdout-path to the dts. The compatible > string provided to OF_EARLYCON_DECLARE will also be changed from > "fsl,s32v234-linflexuart" to "fsl,s32-linflexuart" to match the one in > the device tree nodes. I missed this after importing a rename from our > codebase. > > Should I remove this addition from kernel-parameters.txt after that? Yes, if you can use earlycon instead, then you can drop your custom option entirely and therefore there's no need to document it either. Will
