On 8/7/2019 7:56 PM, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > On Wed, Aug 07, 2019 at 04:42:17PM +0000, Stefan-gabriel Mirea wrote: >> On 8/6/2019 9:40 PM, gregkh@xxxxxxxxxxxxxxxxxxx wrote: >>> On Tue, Aug 06, 2019 at 05:11:17PM +0000, Stefan-gabriel Mirea wrote: <snip> >>>> Other than that, I do not see anything wrong with the addition of a >>>> define in serial_core.h for this purpose (which is also what most of the >>>> serial drivers do, including amba-pl011.c, mentioned in >>>> Documentation/driver-api/serial/driver.rst as providing the reference >>>> implementation), so please be more specific. >>> >>> I am getting tired of dealing with merge issues with that list, and no >>> one seems to be able to find where they are really needed for userspace, >>> especially for new devices. What happens if you do not have use it? >> >> I see. If I drop its usage completely and leave 'type' from the >> uart_port as 0, uart_port_startup() will fail when finding that >> uport->type == PORT_UNKNOWN at [1] (there may be other effects as well, >> e.g. due to the check in uart_configure_port[2]). >> >> So I suppose that I need to define some nonzero 'PORT_KNOWN' macro in >> the driver and use that one internally for 'type'. Is my understanding >> correct? Will there be any problems if I define it to a positive integer >> which is already assigned to another driver, according to serial_core.h? > > Ugh, ok, that's messy, nevermind. Keep the #define in there, I will try > to figure out how to move all of these at once sometime in the future... > > sorry for the noise. No problem, thank you for your time. Regards, Stefan
