On Wed, Aug 07, 2019 at 09:48:03AM -0400, Robert Middleton wrote: > > I'll try to get some firm results in the morning; otherwise I won't be > > able to check until early next week as I will be away from the > > hardware. > > After doing more testing, I think that I finally have something that > is working fully at all baud rates. I've tested this at > 115200,9600,and 4800, testing via: echo "the quick brown fox jumps > over the lazy dog" > /dev/ttySx > > Removing the check to uart_circ_empty in the while loop makes it more > reliable, however it will occasionally fail and only transmit the > first part of the message(at 4800, it will transmit only "t", at > 115200 it will transmit "the quick bro"). I'm not sure about the loop for uart_circ_empty(). Can you try 2-3 kB of text at lower baud rate, let's say 2400 or so? > I've found that breaking it > into two loops, one checking the uart_circ_empty and the other doing > the LSR check is reliable at all baud rates. If my suspicion is correct, the shutdown of the port will take ages which is inappropriate. > I can do a formal patch later, but I just wanted to see if this made > sense first. The second loop is now much simpler, and does not do the > buffer check at the same time, which was probably causing some > problems with the previous version. Thank you for this wise move, I appreciate. -- With Best Regards, Andy Shevchenko
