Reviewed-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
On 2019/8/6 17:43, Andy Shevchenko wrote:
> The commit 2cb78eab2376 ("serial: 8250_dw: Use a unified new dev variable in
> probe") introduced a local dev variable in ->probe(). Do the same in ->remove()
> in order to prepare for sequential patches.
>
> Cc: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/tty/serial/8250/8250_dw.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
> index 284e8d052fc3..7b559f969f61 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -667,8 +667,9 @@ static int dw8250_probe(struct platform_device *pdev)
> static int dw8250_remove(struct platform_device *pdev)
> {
> struct dw8250_data *data = platform_get_drvdata(pdev);
> + struct device *dev = &pdev->dev;
>
> - pm_runtime_get_sync(&pdev->dev);
> + pm_runtime_get_sync(dev);
>
> serial8250_unregister_port(data->line);
>
> @@ -680,8 +681,8 @@ static int dw8250_remove(struct platform_device *pdev)
> if (!IS_ERR(data->clk))
> clk_disable_unprepare(data->clk);
>
> - pm_runtime_disable(&pdev->dev);
> - pm_runtime_put_noidle(&pdev->dev);
> + pm_runtime_disable(dev);
> + pm_runtime_put_noidle(dev);
>
> return 0;
> }
>
