On 06.08.19 09:45, Uwe Kleine-König wrote: > Hello Frieder, > > On Mon, Aug 05, 2019 at 09:01:39AM +0000, Schrempf Frieder wrote: >> On 02.08.19 14:12, Uwe Kleine-König wrote: >>> On Fri, Aug 02, 2019 at 10:04:10AM +0000, Schrempf Frieder wrote: >>>> From: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx> >>>> >>>> As it is allowed to use the mctrl_gpio_* functions before >>>> initialization (as the 8250 driver does according to 434be0ae7aa7), >>> >>> Actually I was surprised some time ago that 8250 used serial_mctrl >>> without first initializing it and expecting it to work. I didn't look in >>> detail, but I wouldn't go so far to call this "allowed". The commit >>> itself calls it "workaround" which seems a better match. >> >> Ok, but if this is considered to be a workaround and as the 8250 driver >> does not use mctrl_gpio_to_gpiod(), we should maybe just drop this patch >> instead of encouraging others to use mctrl_gpio before initialization. >> >> I'm really not sure what's best, so depending on what you will propose, >> I'll send a new version of this patch with adjusted commit message or not. > > I wouldn't encourage usage of mctrl-gpio before it's initialized. So I > suggest to drop this patch. Ok, thanks.
