On 01.08.19 22:39, Uwe Kleine-König wrote: > On Thu, Aug 01, 2019 at 06:45:24PM +0000, Schrempf Frieder wrote: >> From: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx> >> >> Now that the mctrl_gpio code returns NULL instead of ERR_PTR(-ENOSYS) >> in cases when CONFIG_GPIOLIB is disabled, we can safely remove this >> check. > > I would mention -ENOSYS in the Subject line. Something like: > > serial: sh-sci: don't check for mctrl_gpio_init returning -ENOSYS > > Now that the mctrl_gpio code returns NULL instead of > ERR_PTR(-ENOSYS) if CONFIG_GPIOLIB is disabled, we can safely > remove this check. Indeed, I failed to come up with a better subject line. I will adopt your proposal. > Thanks > Uwe >