On Wed, Jul 31, 2019 at 12:45:45PM -0500, Aaron Sierra wrote:
> Move INT0 clearing out of common, per-port serial8250_do_startup()
> into PCI device probe/resume.
>
> As described in commit 2c0ac5b48a35 ("serial: exar: Fix stuck MSIs"),
> the purpose of clearing INT0 is to prevent the PCI interrupt line from
> becoming stuck asserted, "which is fatal with edge-triggered MSIs".
>
> Like the clearing via interrupt handler that moved from common code in
> commit c7e1b4059075 ("tty: serial: exar: Relocate sleep wake-up
> handling"), this clearing at startup can be better handled at the PCI
> device level.
>
> Cc: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
> Cc: Sudip Mukherjee <sudip.mukherjee@xxxxxxxxxxxxxxx>
> Signed-off-by: Aaron Sierra <asierra@xxxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>
> The embedded patch is written to follow this patch from Andy Shevchenko:
> [PATCH v4 3/3] serial: 8250_exar: Move custom divisor support out from 8250_port
It does not apply to my tree after that patch, are you sure about this?
Please rebase against my tty-testing branch and resend.
thanks,
greg k-h
