On Fri, Jul 26, 2019 at 09:52:41PM +0300, Sergey Organov wrote: > Called in only one place, for RS232, it only obscures things, as it > doesn't go well with 2 similar named functions, > imx_uart_rts_inactive() and imx_uart_rts_active(), that both are > RS485-specific. I don't share the critic. IMHO the name is fine. imx_uart_rts_inactive sets rts to its inactive level, imx_uart_rts_active() to its active level and imx_uart_rts_auto() lets the output drive automatically by the receiver. The name started to be a bit wrong in patch 1 of the series however. And I still object removing this function because with the semantic this function got in patch 1 it is suiteable to be used in imx_uart_set_mctrl(). Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
