On Tue, Jul 23, 2019 at 10:43:05AM +0200, Arnd Bergmann wrote: > On Tue, Jul 23, 2019 at 10:26 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > > > On Mon, Jul 22, 2019 at 9:16 PM Arnd Bergmann <arnd@xxxxxxxx> wrote: > > > > > The netx platform got removed, so this driver is now > > > useless. > > > > > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > > > We seem so overlap :) > > https://marc.info/?l=linux-serial&m=156377843325488&w=2 > > > > Anyways, the patches are identical except here: > > > > > -/* Hilscher netx */ > > > +/* Hilscher netx (removed) */ > > > #define PORT_NETX 71 > > > > Is there some reason for keeping the magical number around? > > When I looked over the file there seemed to be more "holes" > > in the list. > > I looked at the same list and though I saw more obsolete entries > than holes. The last ones that I saw getting removed were > PORT_MFD in 2017 and PORT_V850E_UART in 2008. > > It probably doesn't matter as we have precedence for both. I want to just get rid of that whole list as I don't think it's ever needed, but haven't spent the time digging through userspace code to verify it. I'll take Linus's patch as it came first, thanks. greg k-h
