Re: [PATCH] Add driver for SUNIX Serial board.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 23, 2019 at 11:08:13AM +0800, morrisku wrote:
> >On Fri, Jul 19, 2019 at 06:10:50PM +0800, morrisku wrote:
> >> Add Kconfig and Makefile entry.
> >> 
> >> Signed-off-by: Morris Ku <saumah@xxxxxxxxx>
> >> ---
> >>  serial/Kconfig  | 11 +++++++++++
> >>  serial/Makefile |  2 +-
> >>  2 files changed, 12 insertions(+), 1 deletion(-)
> 
> >Same report as the 1/2 patch, and your subject is wrong here :(
> 
> I will modify subject line to [PATCH 2/2] tty/serial: Add driver for SUNIX serial board.
> or [PATCH 2/2] tty:serial: Add driver for SUNIX serial board.
> 
> Is that OK?

You can not have the same subject lines for different patches that do
different things.

> This driver patch separate into 2 patches : 
> Do i need to modify subject line to [PATCH 1/2] and [PATCH 2/2] ?

Why do you need two different patches at all when one of them just adds
the Kconfig and Makefile entries?  Why not do it all in one?

thanks,

greg k-h



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux