> On Wed, Jul 03, 2019 at 12:25:16AM -0700, jeyentam wrote: > > Add NI PXIe-RS232, PXI-RS485 and PXIe-RS485 device IDs. > > > > Signed-off-by: jeyentam <je.yen.tam@xxxxxx> > > --- > > include/linux/pci_ids.h | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > You have read the comment at the top of this file, right? If so, why > are you adding these entries? Yes, but I think these entries should be added in because the NI-Serial PXI (RS232) device IDs already been defined in this file originally, so now I'm adding the newly supported NI-Serial PXI (RS485), PXIe (RS232) and PXIe (RS485) device IDs into here as they are the same product. > > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index > > 70e86148cb1e..7fad4794789f 100644 > > --- a/include/linux/pci_ids.h > > +++ b/include/linux/pci_ids.h > > @@ -1027,7 +1027,9 @@ > > #define PCI_DEVICE_ID_SUN_TOMATILLO 0xa801 > > #define PCI_DEVICE_ID_SUN_CASSINI 0xabba > > > > +/* NI-Serial Device IDs */ > > #define PCI_VENDOR_ID_NI 0x1093 > > That's a vendor id, not a serial device id. Yes, will change it to vendor id. > > thanks, > > greg k-h Thank you. Regards, Je Yen Tam Staff Software Engineer National Instruments o 604-3776397 e je.yen.tam@xxxxxx
