Hello, On Wed, Jun 26, 2019 at 05:11:27PM +0300, Sergey Organov wrote: > imx_uart_set_termios() called imx_uart_rts_active(), or > imx_uart_rts_inactive() before taking port->port.lock. > > As a consequence, sport->port.mctrl that these functions modify > could have been changed without holding port->port.lock. > > Moved locking of port->port.lock above the calls to fix the issue. > > Reviewed-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > Tested-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > Signed-off-by: Sergey Organov <sorganov@xxxxxxxxx> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |