On Thu, Jun 20, 2019 at 09:28:46AM +0200, Oliver Barta wrote: > On Wed, Jun 19, 2019 at 1:20 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > > On Wed, Jun 19, 2019 at 10:16:39AM +0200, Oliver Barta wrote: > > > This reverts commit 2e9fe539108320820016f78ca7704a7342788380. > > > > > > Reading LSR unconditionally but processing the error flags only if > > > UART_IIR_RDI bit was set before in IIR may lead to a loss of transmission > > > error information on UARTs where the transmission error flags are cleared > > > by a read of LSR. Information are lost in case an error is detected right > > > before the read of LSR while processing e.g. an UART_IIR_THRI interrupt. > > > > > > > Perhaps Fixes tag? > > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > > Thank you for the review. I also thought about the Fixes tag but > finally decided not to use it. It is a simple revert, i.e. the subject > of the commit which would be mentioned by the Fixes tag is in the new > subject anyway and the commit ID is referred in the first line of the > commit message body. The Fixes tag would not add any additional > information. I also checked a couple of recent revert commits in the > kernel and noticed that many of them actually don't have this tag. fixes is needed, as I will backport this to the stable trees. I'll add it... thanks, greg k-h
