Lothar Waßmann <LW@xxxxxxxxxxxxxxxxxxx> writes: > Hi, > > On Fri, 14 Jun 2019 15:11:32 +0300 Sergey Organov wrote: >> imx_set_termios() cleared RTS on every call, now fixed. >> >> Signed-off-by: Sergey Organov <sorganov@xxxxxxxxx> >> --- >> drivers/tty/serial/imx.c | 12 ++++++++---- >> 1 file changed, 8 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c >> index 8ee910f..de23068 100644 >> --- a/drivers/tty/serial/imx.c >> +++ b/drivers/tty/serial/imx.c >> @@ -1564,6 +1564,13 @@ imx_uart_set_termios(struct uart_port *port, struct ktermios *termios, >> >> spin_lock_irqsave(&sport->port.lock, flags); >> >> + /* >> + * Read current UCR2 and save it for future use, then clear all the bits >> + * except those we will or may need to preserve. >> + */ >> + old_ucr2 = imx_uart_readl(sport, UCR2); >> + ucr2 = old_ucr2 & (UCR2_TXEN | UCR2_RXEN | UCR2_ATEN | UCR2_CTSC); >> + >> ucr2 = UCR2_SRST | UCR2_IRTS; > s/=/|=/ Nice catch! Thanks, -- Sergey Organov