On 11.06.19 20:52, Greg KH wrote: Hi, >> What's your oppinion on that ?> > Why would this help anything? I just had the naive idea that more compact code was easier to maintain. At least in other areas of the kernel, there seems to be a tendency of moving repeated code patterns into helpers. >> If you like, I can prepare some patches and post them here.> > kernel development is done with actual patches, almost never with "would> this be a good idea", as you never know if it will or not until you> actually do the work. I've made the experience that certain maintainers seem to be quite reluctant of changing anything, if it doesn't fix any actual bug, so I've preferred to ask first, before wasting much time on something that won't be accepted anyways :o --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@xxxxxxxxx -- +49-151-27565287