RE: [EXT] [PATCH v2 1/2] serial: fsl_lpuart: Use dev_info() instead of printk()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Fabio Estevam <festevam@xxxxxxxxx> Sent: Tuesday, June 4, 2019 11:32 AM
> dev_info() is more appropriate for printing messages inside drivers, so switch
> to dev_info().
> 
> Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx>

Reviewed-by: Fugang Duan <fugang.duan@xxxxxxx>
> ---
> Changes since v1:
> - None
> 
>  drivers/tty/serial/fsl_lpuart.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index
> ea1c85e3b432..08b52cca650c 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -2078,7 +2078,7 @@ lpuart_console_get_options(struct lpuart_port
> *sport, int *baud,
>         baud_raw = uartclk / (16 * (sbr + brfa / 32));
> 
>         if (*baud != baud_raw)
> -               printk(KERN_INFO "Serial: Console lpuart rounded baud
> rate"
> +               dev_info(sport->port.dev, "Serial: Console lpuart rounded
> baud rate"
>                                 "from %d to %d\n", baud_raw,
> *baud);  }
> 
> @@ -2121,7 +2121,7 @@ lpuart32_console_get_options(struct lpuart_port
> *sport, int *baud,
>         baud_raw = uartclk / (16 * sbr);
> 
>         if (*baud != baud_raw)
> -               printk(KERN_INFO "Serial: Console lpuart rounded baud
> rate"
> +               dev_info(sport->port.dev, "Serial: Console lpuart rounded
> baud rate"
>                                 "from %d to %d\n", baud_raw,
> *baud);  }
> 
> --
> 2.17.1





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux