On Thu, May 30, 2019 at 06:29:46PM +0300, Sergey Organov wrote: > imx_set_termios(): remove busy-waiting "drain Tx FIFO" loop. Worse > yet, it was potentially unbounded wait due to RTS/CTS (hardware) > handshake. > > Let user space ensure draining is done before termios change, if > draining is needed in the first place. I don't know for sure what the intended behaviour is here, but I tend to think that changing the unbounded wait to a timeout and then return -EBUSY (?) would be more suitable. With your change you're possibly breaking existent software. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
