On Thu, 02 May 2019, Esben Haabendal wrote: > Hi Lee > > Could you help clarify whether or not this patch is trying to do > something odd/wrong? > > I might be misunderstanding Andy (probably is), but the discussion > revolves around the changes I propose where I change the serial8250 > driver to use platform_get_resource() in favour of > request_mem_region()/release_mem_region(). Since 'serial8250' is registered as a platform device, I don't see any reason why it shouldn't have the capability to obtain its memory regions from the platform_get_*() helpers. > In my understanding, use of platform_get_resource() is the right thing > to do in order to integrate properly with with MFD drivers that splits a > common memory resource in mfd_add_device() using the mem_base argument. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog