On Mon, 29 Apr 2019 at 22:31, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > This causes build warnings when applied, I'm having to drop it now. > > Please be more careful, when submitting patches, always test-build them > first. I have found my mistake. Although I have built a kernel to test my patch, I forget to turn on the 8250 configurations which are turned off during another kernel test. As a result, 8250_pnp.c was not compiled at all, so I didn't see any warnings. Sorry for that and thanks for your guidance. I will submit my patch v3.