Re: [PATCH] serdev: add method to set stop bits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 29, 2019 at 09:27:26AM +0300, Fatih Aşıcı wrote:
> On 26 Nisan 2019 Cuma 17:00:02 +03 Rob Herring wrote:
> > On Fri, Apr 12, 2019 at 1:55 AM Fatih Aşıcı <fatih.asici@xxxxxxxxxxxx> 
> wrote:
> > > Adds serdev_device_set_stop_bits() which takes an int argument with
> > > a value of 1 or 2.
> > 
> > Do you have a user? We normally like to have one before adding
> > functions to the kernel.
> 
> We are developing a smartcard interface [1] driver for use in our embedded 
> project. The driver is not suitable for general use.

Why not?  Who's to say what others will find useful?  You have to
publish the changes somewhere, might as well be upstream so you do not
have to drag it around for the next 10+ years :)

Please submit it, we do not add new apis with no in-kernel users.

thanks,

greg k-h



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux