On 29.04.19 11:29, Esben Haabendal wrote: > So maybe we should go down that direction intead, extending 8250 driver > to replace mapbase with a resource struct instead? Yeah, I already was up to do that. But that would be a pretty massive change, as the actual use of fields like mapsize/mapbase in the drivers is so diverse. Some even don't use mapsize. That's why I started harmonizing that step by step. In little steps, that are easier to review (unfortunately, don't have the corresponding hardware to do real tests). Finally, I'd like to have all drivers just use appropriate helpers to declare their IO area and let the core do all the mapping stuff. Then we IMHO could easily switch to struct resource internally. > No, I actually try to do the right thing in relation to Linux device > resource model. But 8250 is just not behaving very well in that > respect, not having been made really aware of the resource model. I see it the same way. The serial (especially 8250) drivers are a tricky thing, and I'd like to make it simpler / easier to understand. But I can understand that Greg is pretty reluctant to any changes, as some actual hardware seems to be hard to get. (OTOH, if it's so rare, could we risk some potential breaks and just wait for anybody complaining ?) --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@xxxxxxxxx -- +49-151-27565287
