checkpatch complaints: WARNING: printk() should include KERN_<LEVEL> facility level #698: FILE: drivers/tty/serial/sb1250-duart.c:698: + printk(err); WARNING: printk() should include KERN_<LEVEL> facility level #706: FILE: drivers/tty/serial/sb1250-duart.c:706: + printk(err); Even though it's a false alarm here (the string is already prefixed w/ KERN_ERR), it's nicer to use pr_err() here, which also makes checkpatch happy. Signed-off-by: Enrico Weigelt <info@xxxxxxxxx> --- drivers/tty/serial/sb1250-duart.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/sb1250-duart.c b/drivers/tty/serial/sb1250-duart.c index b4342c8..227af87 100644 --- a/drivers/tty/serial/sb1250-duart.c +++ b/drivers/tty/serial/sb1250-duart.c @@ -689,13 +689,13 @@ static int sbd_map_port(struct uart_port *uport) static int sbd_request_port(struct uart_port *uport) { - const char *err = KERN_ERR "sbd: Unable to reserve MMIO resource\n"; + const char *err = "sbd: Unable to reserve MMIO resource\n"; struct sbd_duart *duart = to_sport(uport)->duart; int ret = 0; if (!request_mem_region(uport->mapbase, DUART_CHANREG_SPACING, "sb1250-duart")) { - printk(err); + pr_err(err); return -EBUSY; } refcount_inc(&duart->map_guard); @@ -703,7 +703,7 @@ static int sbd_request_port(struct uart_port *uport) if (!request_mem_region(duart->mapctrl, DUART_CHANREG_SPACING, "sb1250-duart")) { refcount_dec(&duart->map_guard); - printk(err); + pr_err(err); ret = -EBUSY; } } -- 1.9.1