On Sat, Apr 27, 2019 at 04:41:44PM +0800, Hao Lee wrote: > On Sat, 27 Apr 2019 at 16:09, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > On Sat, Apr 27, 2019 at 04:00:15PM +0800, Hao Lee wrote: > > > The variable type and the type field is inconsistent. > > > > In what way? Please be very specific when you resend this. > > The main problem is the dev_dbg statement should print the value of > uart.port.mapbase instead of its address. Besides that, uart.port.irq > and uart.port.iotype are all unsigned types, so using %u is more > appropriate. Wonderful, put all of that in the changelog text and please resend. What you submitted is not sufficient. thanks, greg k-h
